refactor: replace abstract visitor hierarchy with contract-based polymorphic dispatch#67
refactor: replace abstract visitor hierarchy with contract-based polymorphic dispatch#67artengin wants to merge 7 commits into
Conversation
|
@codex review |
|
It inherits from this commit: #51 |
Coverage Report for CI Build 25501328605Coverage decreased (-0.06%) to 98.503%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d13ce08389
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| fn ($trait) => new TraitUse([new Name(class_basename($trait))]), | ||
| array_unique(array_filter($this->traits)), |
There was a problem hiding this comment.
getInsertableNodes() now calls array_unique() before class_basename(), so inputs like ['App\\Traits\\Loggable', 'Loggable'] produce two identical TraitUse nodes. filterExistingNodes() only removes traits already present in the file, not duplicates within the new candidate list, so this can emit duplicate use Loggable; entries and generate invalid class composition when the same trait is applied twice.
Useful? React with 👍 / 👎.
3 participants
No description provided.